Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: EKF_CAL: Extended Kalman Filter-based Calibration and Localization #7292

Open
editorialbot opened this issue Sep 26, 2024 · 9 comments

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @JHartzer (Jacob Hartzer)
Repository: https://github.com/unmannedlab/ekf_cal/
Branch with paper.md (empty if default branch):
Version: 0.5
Editor: Pending
Reviewers: Pending
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/18249f1388580f167e28c154365a31d3"><img src="https://joss.theoj.org/papers/18249f1388580f167e28c154365a31d3/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/18249f1388580f167e28c154365a31d3/status.svg)](https://joss.theoj.org/papers/18249f1388580f167e28c154365a31d3)

Author instructions

Thanks for submitting your paper to JOSS @JHartzer. Currently, there isn't a JOSS editor assigned to your paper.

@JHartzer if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Sep 26, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.10 s (2025.6 files/s, 286480.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C++                             76           1930           1351           8611
Python                          13            353            338           2492
CSS                              3            463            144           2140
YAML                            22            138             56           1717
C/C++ Header                    50            650           2294           1657
Perl                             2            144            319           1274
Markdown                        16            143              0            665
JSON                             5              0              0            463
CMake                            1             39             15            200
JavaScript                       4             42             89            156
HTML                             2             14             27             88
TeX                              2              5              0             58
XML                              1              4              3             25
Dockerfile                       1              5              4             24
Bourne Shell                     1              0              0              5
-------------------------------------------------------------------------------
SUM:                           199           3930           4640          19575
-------------------------------------------------------------------------------

Commit count by author:

   526	Jacob
     1	JHartzer
     1	Jacob Hartzer

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1109/SSRR56537.2022.10018692 is OK
- 10.1109/SDF-MFI59545.2023.10361310 is OK
- 10.1109/ICRA40945.2020.9196524 is OK
- 10.48550/arXiv.2205.14087 is OK
- 10.1109/ICRA.2016.7487628 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Computer Vision Toolbox version: 24.1 (R2022b)

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1455

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

imucal - A Python library to calibrate 6 DOF IMUs
Submitting author: @AKuederle
Handling editor: @adi3 (Active)
Reviewers: @tuliofalmeida, @finsberg
Similarity score: 0.7231

AixCaliBuHA: Automated calibration of building and HVAC systems
Submitting author: @FWuellhorst
Handling editor: @fraukewiese (Active)
Reviewers: @samanmostafavi, @shamsiharis
Similarity score: 0.6683

SLAM Toolbox: SLAM for the dynamic world
Submitting author: @stevemacenski
Handling editor: @arfon (Active)
Reviewers: @mosteo, @carlosjoserg
Similarity score: 0.6589

Pose2Sim: An open-source Python package for multiview markerless kinematics
Submitting author: @DavidPagnon
Handling editor: @danasolav (Active)
Reviewers: @lambdaloop, @jonmatthis, @CVHammond
Similarity score: 0.6427

GeoBO: Python package for Multi-Objective Bayesian Optimisation and Joint Inversion in Geosciences
Submitting author: @sebhaan
Handling editor: @hugoledoux (Active)
Reviewers: @npetra, @sgkang
Similarity score: 0.6330

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@kyleniemeyer
Copy link

Hi @JHartzer, we will use this pre-review issue to find an editor and reviewers, and resolve any issues.

Although I can see that your software package meets most of our requirements (documentation, installation instructions, etc.), I'm not sure about a test suite. At minimum, we need instructions on manually testing the full functionality of the software; normally, we want to see—and reviewers will request—an automated test suite for unit and functional testing. (And at best, hooked into continuous integration.)

@JHartzer
Copy link

Hello @kyleniemeyer! Thank you for the initial feedback. I do have a test suite (that is not yet automated) for code testing and coverage. I've updated the main README and documentation landing to hopefully make that a little more clear. I can also take an action to work on a CI pipeline.

As far as reviewer suggestions, here is a list of possibilities from similar authors and a keyword search:

  • AKuederle
  • stevemacenski
  • abougouffa
  • mhu48
  • Mechazo11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants