Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: AutoPDEx: An Automized Partial Differential Equation solver based on JAX #7261

Closed
editorialbot opened this issue Sep 21, 2024 · 32 comments
Assignees
Labels
pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Sep 21, 2024

Submitting author: @BodeTobias (Tobias Bode)
Repository: https://github.com/BodeTobias/AutoPDEx
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @danielskatz
Reviewers: @celliern, @basileMarchand
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d89578e18c80a90afeb1093fa1e25545"><img src="https://joss.theoj.org/papers/d89578e18c80a90afeb1093fa1e25545/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d89578e18c80a90afeb1093fa1e25545/status.svg)](https://joss.theoj.org/papers/d89578e18c80a90afeb1093fa1e25545)

Author instructions

Thanks for submitting your paper to JOSS @BodeTobias. Currently, there isn't a JOSS editor assigned to your paper.

@BodeTobias if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Sep 21, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.33 s (1382.6 files/s, 246513.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                           193           5424            579          47362
Python                          45           2249           4040          13264
SVG                              5              0              0           2698
CSS                             12            307             92           1793
JavaScript                      18            185            283           1203
reStructuredText               178            610            833            546
Jupyter Notebook                 1              0            454            100
YAML                             3             14             10             80
TeX                              1              9              0             79
TOML                             1              6              0             46
Markdown                         3             18              0             35
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                           462           8834           6299          67241
-------------------------------------------------------------------------------

Commit count by author:

    22	BodeTobias

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- None

🟡 SKIP DOIs

- No DOI given, and none found for title: JAX: composable transformations of Python+NumPy pr...
- No DOI given, and none found for title: Efficient and modular implicit differentiation
- No DOI given, and none found for title: Flax: A neural network library and ecosystem for J...
- No DOI given, and none found for title: Equinox: neural networks in JAX via callable PyTre...
- No DOI given, and none found for title: PETSc users manual
- No DOI given, and none found for title: Gmsh: A 3-D finite element mesh generator with bui...
- No DOI given, and none found for title: 36-paraview: An end-user tool for large-data visua...
- No DOI given, and none found for title: Automation of Finite Element Methods

❌ MISSING DOIs

- 10.1016/s0167-739x(03)00188-2 may be a valid DOI for title: Solving unsymmetric sparse systems of linear equat...
- 10.21105/joss.01450 may be a valid DOI for title: PyVista: 3D plotting and mesh analysis through a s...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 451

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU Affero General Public License v3.0 (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

scikit-finite-diff, a new tool for PDE solving
Submitting author: @celliern
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @mrava87, @poulson
Similarity score: 0.7185

py-pde: A Python package for solving partial differential equations
Submitting author: @david-zwicker
Handling editor: @xuanxu (Active)
Reviewers: @celliern, @mstimberg
Similarity score: 0.7157

SGMCMCJax: a lightweight JAX library for stochastic gradient Markov chain Monte Carlo algorithms
Submitting author: @jeremiecoullon
Handling editor: @dfm (Active)
Reviewers: @canyon289, @ColCarroll
Similarity score: 0.7081

Simframe: A Python Framework for Scientific Simulations
Submitting author: @stammler
Handling editor: @taless474 (Retired)
Reviewers: @schruste, @lucaferranti
Similarity score: 0.7067

PyGDH: Python Grid Discretization Helper
Submitting author: @kfhiga
Handling editor: @melissawm (Retired)
Reviewers: @JamieJQuinn, @zhaowei0566
Similarity score: 0.7047

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

danielskatz commented Sep 21, 2024

👋 @BodeTobias - Thanks for your submission. I will assign myself to be the editor.

Please suggest ~5 potential reviewers. You can search the list of people that have already agreed to review and may be suitable for this submission. Or people who aren't in the JOSS system would also be ok. If you know their GitHub usernames, then please mention them here in this thread (without tagging them with an @).

@danielskatz
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @danielskatz is now the editor

@BodeTobias
Copy link

Dear @danielskatz,
thank you for being the editor for my submission! I think the authors and reviewers of the first two similar JOSS papers could be a good fit. The first two of the following list I also found in the list of reviewers:

mrava87
celliern
poulson
dawid-zwicker
mstimberg

@danielskatz
Copy link

👋 @celliern, @mrava87, @poulson, @david-zwicker, @mrava87 - Would a couple of you be willing to review this JOSS submission?

@david-zwicker
Copy link

I'm extremely busy in October, but I could do a review in November if that's not too late.

@danielskatz
Copy link

@david-zwicker - thanks - let me see what other responses I get

@danielskatz
Copy link

👋 @Sm00thix, @parmentelat, @basileMarchand - Would any of you be willing to review this JOSS submission?

@danielskatz
Copy link

👋 @jeremiecoullon, @canyon289, @ColCarroll - Would any of you be willing to review this JOSS submission?

@celliern
Copy link

Hello! I'm not working on pde since a while, so it may be better if other deal with the review. But if there is no other reviewer I could do it.

@mrava87
Copy link

mrava87 commented Sep 25, 2024

Hello! Although the topic is very interesting, I am not currently able to accept the invite due to high workload.

@jeremiecoullon
Copy link

Hello! I don't know a lot about PDE solvers, and I have a high workflow at the moment so I can't help with this unfortunately. :(

@Sm00thix
Copy link

Hi! Thanks for considering me. Unfortunately, I have a high workload for the rest of the year so I will have to decline.

@danielskatz
Copy link

@celliern - I'm going to go ahead and add you, while I continue to look for another review. Thanks for "volunteering"...

@danielskatz
Copy link

@editorialbot add @celliern as reviewer

@editorialbot
Copy link
Collaborator Author

@celliern added to the reviewers list!

@basileMarchand
Copy link

basileMarchand commented Sep 26, 2024

Hello, @danielskatz I'm interested in the topic. I'm up for taking part in the review.

@danielskatz
Copy link

Thanks @basileMarchand - I'll add you in the system, but keep waiting a little to start the review, as I would like to get three reviewers if I can

@danielskatz
Copy link

@editorialbot add @basileMarchand as reviewer

@editorialbot
Copy link
Collaborator Author

@basileMarchand added to the reviewers list!

@parmentelat
Copy link

hello @danielskatz
thanks for the invitation, but I have very little to do with pde's so this is definitely very far from my comfort area, and I will have to decline, but thanks again

@celliern
Copy link

@celliern - I'm going to go ahead and add you, while I continue to look for another review. Thanks for "volunteering"...

it's ok, my pde times are not that far away, and I can spare some evening doing the review :)

@danielskatz
Copy link

Thanks - with @celliern's nice comment, I'm going to go ahead and start the review now

@danielskatz
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7300.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

10 participants