Skip to content

Commit c3ee1a3

Browse files
8239822: Intermittent unit test failures in RegionCSSTest
Reviewed-by: aghaisas
1 parent 3150562 commit c3ee1a3

File tree

3 files changed

+39
-10
lines changed

3 files changed

+39
-10
lines changed

modules/javafx.graphics/src/test/java/test/com/sun/javafx/css/StyleManagerTest.java

+12-2
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
import javafx.scene.paint.Color;
4242
import javafx.scene.paint.Paint;
4343
import javafx.scene.shape.Rectangle;
44+
import org.junit.AfterClass;
4445
import org.junit.Before;
4546
import org.junit.Test;
4647

@@ -62,8 +63,7 @@ public class StyleManagerTest {
6263
public StyleManagerTest() {
6364
}
6465

65-
@Before
66-
public void setUp() {
66+
private static void resetStyleManager() {
6767
StyleManagerShim sm = StyleManagerShim.getInstance();
6868
sm.userAgentStylesheetContainers_clear();
6969
sm.platformUserAgentStylesheetContainers_clear();
@@ -72,6 +72,16 @@ public void setUp() {
7272
sm.set_hasDefaultUserAgentStylesheet(false);
7373
}
7474

75+
@Before
76+
public void setUp() {
77+
resetStyleManager();
78+
}
79+
80+
@AfterClass
81+
public static void cleanupOnce() {
82+
resetStyleManager();
83+
}
84+
7585
@Test
7686
public void testMethod_getInstance() {
7787
Scene scene = new Scene(new Group());

modules/javafx.graphics/src/test/java/test/javafx/css/Node_cssStateTransition_Test.java

+12-2
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
import javafx.scene.shape.Rectangle;
4242
import static org.junit.Assert.*;
4343

44+
import org.junit.AfterClass;
4445
import org.junit.Before;
4546
import org.junit.Test;
4647

@@ -49,8 +50,7 @@ public class Node_cssStateTransition_Test {
4950
public Node_cssStateTransition_Test() {
5051
}
5152

52-
@Before
53-
public void setUp() {
53+
private static void resetStyleManager() {
5454
StyleManager sm = StyleManager.getInstance();
5555
sm.userAgentStylesheetContainers.clear();
5656
sm.platformUserAgentStylesheetContainers.clear();
@@ -59,6 +59,16 @@ public void setUp() {
5959
sm.hasDefaultUserAgentStylesheet = false;
6060
}
6161

62+
@Before
63+
public void setUp() {
64+
resetStyleManager();
65+
}
66+
67+
@AfterClass
68+
public static void cleanupOnce() {
69+
resetStyleManager();
70+
}
71+
6272
@Test
6373
public void testPropertiesResetOnStyleclassChange() {
6474

modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java

+15-6
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
import static org.junit.Assert.assertFalse;
4141
import static org.junit.Assert.assertNull;
4242
import static org.junit.Assert.assertTrue;
43+
import org.junit.AfterClass;
4344
import org.junit.Before;
4445
import org.junit.Test;
4546

@@ -49,19 +50,27 @@ public class CssStyleHelperTest {
4950
private Stage stage;
5051
private StackPane root;
5152

53+
private static void resetStyleManager() {
54+
StyleManager sm = StyleManager.getInstance();
55+
sm.userAgentStylesheetContainers.clear();
56+
sm.platformUserAgentStylesheetContainers.clear();
57+
sm.stylesheetContainerMap.clear();
58+
sm.cacheContainerMap.clear();
59+
sm.hasDefaultUserAgentStylesheet = false;
60+
}
61+
5262
@Before
5363
public void setup() {
5464
root = new StackPane();
5565
scene = new Scene(root);
5666
stage = new Stage();
5767
stage.setScene(scene);
68+
resetStyleManager();
69+
}
5870

59-
StyleManager sm = StyleManager.getInstance();
60-
sm.userAgentStylesheetContainers.clear();
61-
sm.platformUserAgentStylesheetContainers.clear();
62-
sm.stylesheetContainerMap.clear();
63-
sm.cacheContainerMap.clear();
64-
sm.hasDefaultUserAgentStylesheet = false;
71+
@AfterClass
72+
public static void cleanupOnce() {
73+
resetStyleManager();
6574
}
6675

6776
@Test

0 commit comments

Comments
 (0)