8367690: C2: Unneeded branch in reduce_phi

Anton Seoane Ampudia · robcasloz · commit bdfd5e843a7d · 2025-10-22T09:08:26.000Z
Reviewed-by: rcastanedalo, chagedorn
diff --git a/src/hotspot/share/opto/escape.cpp b/src/hotspot/share/opto/escape.cpp
@@ -1296,9 +1296,8 @@ void ConnectionGraph::reduce_phi(PhiNode* ophi, GrowableArray<Node *>  &alloc_wo
       castpps.push(use);
     } else if (use->is_AddP() || use->is_Cmp()) {
       others.push(use);
-    } else if (use->is_SafePoint()) {
-      // processed later
     } else {
+      // Safepoints to be processed later; other users aren't expected here
       assert(use->is_SafePoint(), "Unexpected user of reducible Phi %d -> %d:%s:%d", ophi->_idx, use->_idx, use->Name(), use->outcnt());
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -1296,9 +1296,8 @@ void ConnectionGraph::reduce_phi(PhiNode* ophi, GrowableArray<Node *> &alloc_wo`
`1296`	`1296`	`castpps.push(use);`
`1297`	`1297`	`} else if (use->is_AddP() \|\| use->is_Cmp()) {`
`1298`	`1298`	`others.push(use);`
`1299`		`- } else if (use->is_SafePoint()) {`
`1300`		`- // processed later`
`1301`	`1299`	`} else {`
	`1300`	`+ // Safepoints to be processed later; other users aren't expected here`
`1302`	`1301`	`assert(use->is_SafePoint(), "Unexpected user of reducible Phi %d -> %d:%s:%d", ophi->_idx, use->_idx, use->Name(), use->outcnt());`
`1303`	`1302`	`}`
`1304`	`1303`	`}`