Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVA6 arch tests are failing with latest riscof environment #1283

Closed
spidugu444 opened this issue May 31, 2022 · 10 comments
Closed

CVA6 arch tests are failing with latest riscof environment #1283

spidugu444 opened this issue May 31, 2022 · 10 comments
Assignees
Labels
bug Something isn't working cva6

Comments

@spidugu444
Copy link
Contributor

spidugu444 commented May 31, 2022

Issue Description

HI

In latest RISCOF CVA6 riscv-arch-tests tests are failing due to mismatch in between spike and verilator csv.
I used cva6_spike_log_to_trace_csv.py script for spike log to csv conversion.
As shown below some lines are missing in spike csv which has been presented in spike log.

Screenshot from 2022-05-31 17-52-29

image

Note: I tried same scirpt for riscv-compliance-tests which is working fine.

please find the spike log and csv files attached below.

addi-01.log
addi-01.csv

Description of Done

Need help in resolving above issue.

@spidugu444 spidugu444 added the task Assignment to create something new label May 31, 2022
@spidugu444 spidugu444 changed the title [TASK] CVA6 arch tests are failing with latest riscof infrastructure [TASK] CVA6 arch tests are failing with latest riscof environment May 31, 2022
@MikeOpenHWGroup MikeOpenHWGroup added bug Something isn't working cva6 and removed task Assignment to create something new labels May 31, 2022
@MikeOpenHWGroup
Copy link
Member

Hi @JeanRochCoulon, I am not sure who should look at this, so I assigned it to you. Please assign to the appropriate person.

@JeanRochCoulon
Copy link
Contributor

@ASintzoff is the right person !

@spidugu444
Copy link
Contributor Author

@ASintzoff Please find the setup that I used to set RISCOF dv-arch-test suite.

@umerimran-10xe
Copy link

@spidugu444 Please use the version 1.1.0 release of Spike. I think its because some stuff is updated in the master branch of riscv-isa-sim and we have not currently incorporated these changes in cva6_spike_log_to_trace_csv.py file.
The Spike 1.1.0 version will resolve the problems related to RISCV-Arch tests mismatch as log is not generated according to how our log to csv trace works.

cc/ @fatimasaleem

@MikeOpenHWGroup MikeOpenHWGroup changed the title [TASK] CVA6 arch tests are failing with latest riscof environment CVA6 arch tests are failing with latest riscof environment Jun 6, 2022
@MikeOpenHWGroup
Copy link
Member

There is some confusion between a task and an issue. We use GitHub Issues to create and track both.

A task is new work that must be done in order for the project to achieve its goals. Examples include integrating the RISCOF, adding a new verification component and creating a new test-program.

An issue is a problem with the current state of the repository. Everyone's favourite example is a bug in the RTL, and it can also be a problem in any other code/scripts or even a problem with documentation.

This particular GitHub issue is an issue, not a task.

@Imperas
Copy link

Imperas commented Jun 17, 2022

In latest RISCOF CVA6 riscv-arch-tests tests are failing due to mismatch in between spike and verilator csv.

I am a little confused by the above statement.

RISCOF is a python framework from RISC-V International Arch Test SIG that uses signature compare from the reference models to your DUT. there is no CSV in RISCOF - are you confusing this with Google RISCV-DV which does a CSV and has scripts like log_to_trace_csv.py?
Simon

@fatimasaleem
Copy link
Contributor

fatimasaleem commented Jun 19, 2022

RISCOF is a python framework from RISC-V International Arch Test SIG that uses signature compare from the reference models to your DUT. there is no CSV in RISCOF - are you confusing this with Google RISCV-DV which does a CSV and has scripts like log_to_trace_csv.py?

Hi @Imperas
Actually, we have not incorporated the RISCOF python framework in the core-v-verif infrastructure rather we have made some necessary changes to run the RISCOF compatible arch tests in the already existing verification environment of core-v-verif. We are running the latest arch-tests on spike and DUT, and comparing using the CSV. We are not using the sail as a reference model while running the arch tests in core-v-verif infrastructure.

@spidugu444
Copy link
Contributor Author

with updated version of spike issue got resolved and I am closing this issue.

@JeanRochCoulon
Copy link
Contributor

Great ! @spidugu444 Could you indicate the Spike version which fails and the Spike version which passes ? To avoid using the bad version !!

@spidugu444
Copy link
Contributor Author

@JeanRochCoulon I faced issue while I was using commit id: e93b9cbbbcd3ad0a02ae298e9f1a2d98d3ac0153,but with latest version spike 1.1.0 issue got resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cva6
Projects
None yet
Development

No branches or pull requests

7 participants