-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shelly] Fix initialization of BLU Motion device #17053
Conversation
… flags for BLU devices in general and for BLU Motion another one) Signed-off-by: Markus Michels <[email protected]>
"awaiting feedback" tag is used when a reviewer is awaiting a feedback from the contributor, not the reverse. Putting it could lead to your PR being "ignored" or put in very low priority ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! I have added two very minor comments regarding logging, otherwise LGTM. Please ping when tested/verified (I replaced the label, see @lolodomo's comment).
...ding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java
Outdated
Show resolved
Hide resolved
...ding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java
Show resolved
Hide resolved
...inding.shelly/src/main/java/org/openhab/binding/shelly/internal/api/ShellyDeviceProfile.java
Show resolved
Hide resolved
@jlaur I did some testing with 10 BLU DW and 2 BLU Motion sensors, also 3 different Shelly acting as hub Nevertheless, I saw "BLU Device not yet connected" which shouldn't show up on device initialization. I'm still chasing, it's hard to reproduce so it makes sense to merge this PR and add another one when I have a fix. |
Signed-off-by: Jacob Laursen <[email protected]>
Fix: ``` [WARNING] .binding.shelly/README.md:[217] The line before a Markdown list must be empty. [WARNING] .binding.shelly/README.md:[218] The line after a Markdown list must be empty. ``` Signed-off-by: Jacob Laursen <[email protected]>
* Fixes #17052 (caused by inproper initialization of the profile flags for BLU devices in general and for BLU Motion another one) Signed-off-by: Markus Michels <[email protected]>
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
* Fixes openhab#17052 (caused by inproper initialization of the profile flags for BLU devices in general and for BLU Motion another one) Signed-off-by: Markus Michels <[email protected]>
This PR fixes BLU motion initialization. In facts various flag in the device profile were not correctly initialized. This also affected other BLU devices even they seem to work.
This also should be back ported to 4.2 (cheeky picking)
Fixes #17052