[shelly] Fix initialization of BLU Motion device #17053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flags for BLU devices in general and for BLU Motion another one) Signed-off-by: Markus Michels <[email protected]>
markus7017
added
bug
jlaur
changed the title
markus7017
changed the title
|
"awaiting feedback" tag is used when a reviewer is awaiting a feedback from the contributor, not the reverse. Putting it could lead to your PR being "ignored" or put in very low priority ! |
jlaur
added
additional testing preferred
jlaur
requested changes
Jul 14, 2024
...ding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java
Outdated
Show resolved
Hide resolved
...ding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java
Show resolved
Hide resolved
jlaur
reviewed
Jul 14, 2024
...inding.shelly/src/main/java/org/openhab/binding/shelly/internal/api/ShellyDeviceProfile.java
Show resolved
Hide resolved
markus7017
added
community approved
and removed
additional testing preferred
|
@jlaur I did some testing with 10 BLU DW and 2 BLU Motion sensors, also 3 different Shelly acting as hub Nevertheless, I saw "BLU Device not yet connected" which shouldn't show up on device initialization. I'm still chasing, it's hard to reproduce so it makes sense to merge this PR and add another one when I have a fix. |
Signed-off-by: Jacob Laursen <[email protected]>
jlaur
approved these changes
Jul 16, 2024
jlaur
reviewed
Jul 16, 2024
jlaur
reviewed
Jul 16, 2024
Fix: ``` [WARNING] .binding.shelly/README.md:[217] The line before a Markdown list must be empty. [WARNING] .binding.shelly/README.md:[218] The line after a Markdown list must be empty. ``` Signed-off-by: Jacob Laursen <[email protected]>
jlaur
pushed a commit
that referenced
this pull request
Jul 16, 2024
* Fixes #17052 (caused by inproper initialization of the profile flags for BLU devices in general and for BLU Motion another one) Signed-off-by: Markus Michels <[email protected]>
jlaur
changed the title
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Jul 18, 2024
* Fixes openhab#17052 (caused by inproper initialization of the profile flags for BLU devices in general and for BLU Motion another one) Signed-off-by: Markus Michels <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes BLU motion initialization. In facts various flag in the device profile were not correctly initialized. This also affected other BLU devices even they seem to work.
This also should be back ported to 4.2 (cheeky picking)
Fixes #17052