-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[govee] binding crashes silently if receiving "wrong" values #17041
Comments
This issue has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/govee-dreamcoulour-led-strips/84435/67 |
This is in essential an external bug. The supplier promised a fix in the near future. The fix will probably be available before the next stable release. I doubt someone will pick this up and create a very temporary fix. |
That's right, but the binding shouldn't crash completely and stop working for other lamps either, should it? At least a proper error handling without crash, but with log entry should be implemented... |
The Thing remains online but unresponsive, just like the others? Can you provide a debug log ? |
Maybe I didn't express myself precisely enough, since most of it has already been described in the thread... Exactly, the binding "crashes" without there being a log entry, not even in the logging level DEBUG! The binding crashes in such a way that none of the defined things work anymore, not only the one with the "wrong" values...
I have seen your pr and I think it should work like this :) |
Expected Behavior
Locally control my govee lamps and receive the current status.
Even if the return values of a lamp are "wrong", the binding should not crash and control should still be possible.
Current Behavior
When receiving the current status of my H60A1 lamp, the binding crashes quietly and no new values can be received. Not even for other lamps!
Possible Solution
Ignore "wrong" values, but still allow the control.
Steps to Reproduce (for Bugs)
The following values cause the govee binding to crash silently without any log entrys:
{"msg": {"cmd": "devStatus", "data": {"onOff": 0, "brightness": 100, "color": {"r": 1, "g": 10, "b": 0}, "colorTemInKelvin": 9070}}}
If “colorTemInKelvin” >= 9070, the value of “onOff” does not matter.
{"msg": {"cmd": "devStatus", "data": {"onOff": 1, "brightness": 101, "color": {"r": 1, "g": 10, "b": 0}, "colorTemInKelvin": 9096}}}
If “onOff” = 1 and “brightness” >= 101.
Context
It is known that the H60A1 lamp returns "wrong" values via the local api. Govee has promised a solution/update for August...
https://community.openhab.org/t/govee-dreamcoulour-led-strips/84435/64
Your Environment
openHAB v4.1.3
ubunut 22.04.4 LTS
The text was updated successfully, but these errors were encountered: