Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running CI from a fork doesn't work #29

Open
ntBre opened this issue Dec 19, 2024 · 0 comments
Open

Running CI from a fork doesn't work #29

ntBre opened this issue Dec 19, 2024 · 0 comments

Comments

@ntBre
Copy link
Collaborator

ntBre commented Dec 19, 2024

See #28. The optimization benchmark failed with

Traceback (most recent call last):
  File "/home/ubuntu/_work/yammbs-dataset-submission/yammbs-dataset-submission/main.py", line 62, in <module>
    conf = Config.from_file(sys.argv[1])
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/_work/yammbs-dataset-submission/yammbs-dataset-submission/config.py", line 13, in from_file
    with open(filename) as inp:
         ^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'submissions/2024-12-19-Sage-2.2.1-lipids-aux/input.yaml'

In other words, it can't find the YAML file input file, despite my having copied the file path from the GitHub UI (I also pulled the branch locally and ls submissions/2024-12-19-Sage-2.2.1-lipids-aux/input.yaml runs just fine from the root of the repo).

Under the checkout action, the hash being printed is '7e22ab606b080e9696411140797fa76a06abd966', which corresponds to the master branch (the last torsion benchmark run correctly prints 'd184dcf4574c04a0f08cf50131ad37b1c1d224cd', which is the penultimate commit in the torsion branch). My hypothesis is that the fork is confusing the checkout process, which can possibly be fixed based on this comment: actions/checkout#455 (comment), which suggests adding these options to the checkout action:

      - name: Clone repository
        uses: actions/checkout@v2
        with:
          fetch-depth: 0
          ref: ${{github.event.pull_request.head.ref}}
          repository: ${{github.event.pull_request.head.repo.full_name}}

I was going to try making this modification directly on @JHoeflich1's branch, but I needed push permissions in the fork. As the linked comment indicates, even if the checkout action pulls the right code with this modification, I think we'll run into the same issue with trying to commit back to the fork.

In short, the current workflow may just not work for forks, which is a little unfortunate. But I wanted to flag it for further investigation after the holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant