-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dq_petfood_beauty_brands #9340
Conversation
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9340 +/- ##
==========================================
+ Coverage 48.18% 48.21% +0.02%
==========================================
Files 65 65
Lines 20348 20348
Branches 4932 4933 +1
==========================================
+ Hits 9805 9811 +6
+ Misses 9288 9284 -4
+ Partials 1255 1253 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
What
Added quality facets to find pet food as well cosmetics in Open Food Facts.
Based on the brand's list of Open Pet Food Facts and Open Beauty Facts, respectively. It does not include ALL brands, but brands having more than 4 products for Open Pet Food Facts and 10 products for Open Beauty Facts.
I would suggest converting them to error, and to remove false positive (if any) overtime.
Screenshot
Related issue(s) and discussion