Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dq_petfood_beauty_brands #9340

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

benbenben2
Copy link
Collaborator

What

Added quality facets to find pet food as well cosmetics in Open Food Facts.

Based on the brand's list of Open Pet Food Facts and Open Beauty Facts, respectively. It does not include ALL brands, but brands having more than 4 products for Open Pet Food Facts and 10 products for Open Beauty Facts.

I would suggest converting them to error, and to remove false positive (if any) overtime.

Screenshot

Screenshot_20231119_161016

Related issue(s) and discussion

@benbenben2 benbenben2 added brands Not taxonomized yet. https://wiki.openfoodfacts.org/Brands 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧽 Data quality - Measure - Quality facets One of the facets available in Open Food Facts is /quality & allows us to spot products w/ bad data open pet food facts labels Nov 19, 2023
@benbenben2 benbenben2 self-assigned this Nov 19, 2023
@benbenben2 benbenben2 requested a review from a team as a code owner November 19, 2023 15:19
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests and removed 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org labels Nov 19, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba6739f) 48.18% compared to head (3f528ad) 48.21%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9340      +/-   ##
==========================================
+ Coverage   48.18%   48.21%   +0.02%     
==========================================
  Files          65       65              
  Lines       20348    20348              
  Branches     4932     4933       +1     
==========================================
+ Hits         9805     9811       +6     
+ Misses       9288     9284       -4     
+ Partials     1255     1253       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@stephanegigandet stephanegigandet merged commit 6e00ac4 into main Nov 20, 2023
@stephanegigandet stephanegigandet deleted the dq_petfood_beauty_brands branch November 20, 2023 13:45
alexgarel pushed a commit that referenced this pull request Nov 21, 2023
@teolemon teolemon added 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org and removed open beauty facts labels May 11, 2024
@teolemon teolemon added the 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brands Not taxonomized yet. https://wiki.openfoodfacts.org/Brands 🧽 Data quality - Measure - Quality facets One of the facets available in Open Food Facts is /quality & allows us to spot products w/ bad data 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
Status: In progress
Status: In progress
Status: Done
Development

Successfully merging this pull request may close these issues.

Quality facet - find cosmetics in Open Food Facts Quality facets - find petfood in Open Food Facts
4 participants