fix: fix_avoid_eiweiss_false_positive_for_allergens #9317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is due to underscores. Replacing: "_Weizen_eiweiß" by: "Weizen eiweiß" or "Weizeneiweiß" avoids having the eggs allergen.
For other allergens, the following regex seems to work:
However, in the case of _Weizen_eiweiß it leads to 2 allergens. Hence, suggested solution is to add (for German only to minimize probability of false positive) the case when underscore after the allergen is not at the end of the word (remove \b of the previous line. This is done only for \b after the allergen, not before, again to minimize probability of false positive).
Screenshot
Related issue(s) and discussion