Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set caching headers for assetlinks.json #9270

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

stephanegigandet
Copy link
Contributor

Seems to divide by 10 the 2500 requests per minute we had on Open Pet Food Facts from GoogleAssociationService.
openfoodfacts/openfoodfacts-infrastructure#264

before change:

root@opff:/var/log/nginx# tail -n 1000000 opff-access.log | grep GoogleAssociationService | grep 2023:15:00: | wc -l
2029
root@opff:/var/log/nginx# tail -n 1000000 opff-access.log | grep GoogleAssociationService | grep 2023:15:05: | wc -l
2468
root@opff:/var/log/nginx# tail -n 1000000 opff-access.log | grep GoogleAssociationService | grep 2023:15:15: | wc -l
2510

after change:

root@opff:/var/log/nginx# tail -n 1000000 opff-access.log | grep GoogleAssociationService | grep 2023:15:30: | wc -l
136
root@opff:/var/log/nginx# tail -n 1000000 opff-access.log | grep GoogleAssociationService | grep 2023:15:35: | wc -l
177
root@opff:/var/log/nginx# tail -n 1000000 opff-access.log | grep GoogleAssociationService | grep 2023:15:40: | wc -l
201

@stephanegigandet stephanegigandet requested a review from a team as a code owner November 8, 2023 15:45
@github-actions github-actions bot added 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org NGINX labels Nov 8, 2023
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet
Copy link
Contributor Author

root@opff:/var/log/nginx# tail -n 1000000 opff-access.log | grep GoogleAssociationService | grep 2023:16:00: | wc -l
21

root@opff:/var/log/nginx# tail -n 1000000 opff-access.log | grep GoogleAssociationService | grep 2023:16:15: | wc -l
27

@codecov-commenter
Copy link

Codecov Report

Merging #9270 (b00d64a) into main (3cde3fc) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #9270   +/-   ##
=======================================
  Coverage   47.95%   47.95%           
=======================================
  Files          65       65           
  Lines       20277    20277           
  Branches     4914     4914           
=======================================
  Hits         9724     9724           
  Misses       9301     9301           
  Partials     1252     1252           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NGINX 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants