-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Nutri-Score for olive oils with unrecognized ingredients #9247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
taxonomies/categories.txt
Outdated
@@ -35242,7 +35242,7 @@ wikidata:en:Q1163138 | |||
ciqual_food_code:en:31027 | |||
ciqual_food_name:en:Candied fruits | |||
ciqual_food_name:fr:Fruit confit | |||
nutriscore_without_unprocessed_fruits_vegetables_legumes:en:yes | |||
nutriscore_category_override_for_fruits_vegetables_legumes:en: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we any documentation on how this property works ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexgarel I'm adding a comment for it at the top of the taxonomy, where there is some doc for some properties already.
Kudos, SonarCloud Quality Gate passed! |
so the category defines the nutriscore. You can also let it define the ingredient (so you get the right nutriscore?). |
@aleene We already have a mechanism for that in fact (added by @benbenben2 ),
|
Can't you the expected_ingredient field to calculate the nutriscore? |
This PR: