Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add knowledge content to additive knowledge panels #9103

Merged
merged 3 commits into from
Oct 3, 2023
Merged

feat: add knowledge content to additive knowledge panels #9103

merged 3 commits into from
Oct 3, 2023

Conversation

raphael0202
Copy link
Contributor

@raphael0202 raphael0202 commented Oct 2, 2023 •
edited
Loading

Allow to easily change the knowledge content for additive knowledge panels. Content is stored in openfoodfacts-web.

Before:
Capture d’écran du 2023-10-02 17-21-25

After:
Capture d’écran du 2023-10-02 17-22-28

@raphael0202 raphael0202 requested a review from a team as a code owner October 2, 2023 15:15
@github-actions github-actions bot added 🧪 additives 🧪 tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Tags 🧪 unit tests labels Oct 2, 2023
@raphael0202 raphael0202 added 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels 🧪 additives and removed 🧪 additives 🧪 tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Tags 🧪 unit tests labels Oct 2, 2023
@github-actions github-actions bot added 🧪 tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Tags 🧪 unit tests labels Oct 3, 2023
stephanegigandet
stephanegigandet approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@raphael0202 raphael0202 enabled auto-merge (squash) October 3, 2023 14:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@raphael0202 raphael0202 merged commit 7bb6af2 into main Oct 3, 2023
@raphael0202 raphael0202 deleted the add-knowledge-additive branch October 3, 2023 14:41
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@raphael0202 raphael0202

Labels
🧪 additives 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Tags Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests 🧪 unit tests
Projects
📖 Knowledge panels
Status: To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphael0202 @stephanegigandet