fix: add support to import CSV file with multiple image urls for one product on separate rows (Carrefour) + fix fake download of images for tests #9058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Data import
🖼️ Images
🧪 tests
🏭 Producers Platform
stephanegigandet
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
raphael0202
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for Carrefour that will send us CSV files with images urls (1 line per image, with several images per product).
Also added some tests and repaired the fake_download_image() mock used in the test which did not work (images were not downloaded and imported).
Added support for CSV files that use a ; as a separator (with very basic detection).