fix: return empty noindex webpage when crawlers hit specific pages #8744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgarel
approved these changes
Jul 27, 2023
when a crawler hit nested facets (ex: /category/popcorn-with-caramel/data-quality-error/nutrition-value-total-over-105) we return a blank HTML page with a noindex directive to prevent the crawler from overloading our servers.
The User-Agent has changed: see https://bot.seekport.com/
raphael0202
force-pushed
the
add-no-index
branch
from
18d6b57 to
95ce78d
Compare
raphael0202
force-pushed
the
add-no-index
branch
2 times, most recently
from
a88949f to
c1f3cdc
Compare
Codecov Report
@@ Coverage Diff @@
## main #8744 +/- ##
==========================================
- Coverage 48.78% 48.73% -0.06%
==========================================
Files 117 117
Lines 21882 21908 +26
Branches 4869 4872 +3
==========================================
+ Hits 10676 10677 +1
- Misses 9903 9927 +24
- Partials 1303 1304 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
raphael0202
force-pushed
the
add-no-index
branch
from
c1f3cdc to
b76fcfa
Compare
Crawling bots can't visit all page and crawl OFF continuously. We want to limit crawlers on interesting pages, so we return a noindex html page on most facet pages (except most interesting ones such as brand, category,...)
raphael0202
force-pushed
the
add-no-index
branch
from
b76fcfa to
0e82a6f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Jul 28, 2023
| @@ -564,6 +569,24 @@ sub analyze_request ($request_ref) { | |||
| $request_ref->{text} = 'index-pro'; | |||
| } | |||
|
|
|||
| # Return noindex empty HTML page for web crawlers that crawl specific facet pages | |||
| if (($request_ref->{is_crawl_bot} eq 1) and (defined $request_ref->{tagtype})) { | |||
There was a problem hiding this comment.
the "eq" operator converts both values to a string before comparing, it's best to use == for numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An analysis of nginx logs made us realize that 6% of our traffic was due to Bing bot, half of the queries were "facet" queries that involve aggregate MongoDB queries and consume a lot of resources.
See https://openfoodfacts.slack.com/archives/C1FPYCWM7/p1690454042958259 discussion for more context.
As a result, we decided to prevent known crawlers from crawling nested facet pages (2 facets). This should limit drastically the number of crawlable pages and reduce server load (especially the DB server).
I checked locally with custom User Agent, nested facet pages are blocked as expected.