Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Hide/Show toggle eye icon beside password field #8713

Merged
merged 5 commits into from
Jul 31, 2023

Conversation

MonalikaPatnaik
Copy link
Collaborator

What

Screenshot

in user sign-in form

image

in user-registration-form

image

Related issue(s) and discussion

  • Fixes #[ISSUE NUMBER]

@MonalikaPatnaik MonalikaPatnaik requested a review from a team as a code owner July 20, 2023 21:31
@github-actions github-actions bot added Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 👥 Users labels Jul 20, 2023
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good idea, but there are some details to take care of !

templates/web/pages/session/sign_in_form.tt.html Outdated Show resolved Hide resolved
templates/web/pages/session/sign_in_form.tt.html Outdated Show resolved Hide resolved
templates/web/pages/session/sign_in_form.tt.html Outdated Show resolved Hide resolved
@github-actions github-actions bot added the CSS label Jul 21, 2023
@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Jul 25, 2023
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good @MonalikaPatnaik !

Only an indentation fix and you can merge :-)

scss/_off.scss Outdated Show resolved Hide resolved
@MonalikaPatnaik MonalikaPatnaik force-pushed the add-eye-icon branch 2 times, most recently from dae2a76 to c7f1616 Compare July 27, 2023 20:39
@MonalikaPatnaik
Copy link
Collaborator Author

Thankyou so much..I think we could merge <3

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Jul 28, 2023
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit c223b0a into openfoodfacts:main Jul 31, 2023
@MonalikaPatnaik MonalikaPatnaik deleted the add-eye-icon branch January 4, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 👥 Users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants