Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: Various Japanese translations (merge from Naruyoko PR #8405) #8558

Merged
merged 29 commits into from
Jun 19, 2023

Conversation

stephanegigandet
Copy link
Contributor

Merged main branch inside @Naruyoko's branch from PR #8405 and resolved conflicts.

Naruyoko and others added 25 commits April 23, 2023 17:57
Most are already seen in the OFF database
@stephanegigandet
Copy link
Contributor Author

Changes from the conflict resolution: 48e902e

@stephanegigandet
Copy link
Contributor Author

3 Japanese names are used for 2 different entries:

Errors in the categories taxonomy definition:
ERROR - ja:赤米 already is associated to en:red-rices (categories) - ja:赤米 cannot be mapped to entry en:black-rices
ERROR - ja:豚ロース already is associated to en:cooked-pork-loin (categories) - ja:豚ロース cannot be mapped to entry en:pork-loin
ERROR - ja:スパゲッティ・アッラ・タリアテッレ already is associated to en:tagliatelle-with-carbonara (categories) - ja:スパゲッティ・アッラ・タリアテッレ cannot be mapped to entry en:bolognese-tagliatelle

@stephanegigandet stephanegigandet requested a review from a team as a code owner June 15, 2023 14:14
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Merging #8558 (2041344) into main (6a294d0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8558   +/-   ##
=======================================
  Coverage   48.70%   48.70%           
=======================================
  Files         114      114           
  Lines       21412    21412           
  Branches     4789     4789           
=======================================
  Hits        10429    10429           
  Misses       9698     9698           
  Partials     1285     1285           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Jun 16, 2023
@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Jun 19, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Naruyoko and @stephanegigandet !

@alexgarel alexgarel merged commit df1d873 into main Jun 19, 2023
@alexgarel alexgarel deleted the naruyoko-merge branch June 19, 2023 13:01
@teolemon teolemon added the 🇯🇵 Japan https://jp.openfoodfacts.org/ label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 additives categories 🥗 Ingredients 🇯🇵 Japan https://jp.openfoodfacts.org/ 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants