Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove File::Fetch #8175

Merged
merged 2 commits into from
Mar 10, 2023
Merged

fix: remove File::Fetch #8175

merged 2 commits into from
Mar 10, 2023

Conversation

stephanegigandet
Copy link
Contributor

File::Fetch is causing issues in the prod and dev environment (but not in docker, maybe because of different versions).

I'm removing it in favor of LWP::UserAgent (which we already use).

fixes #8172

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea !

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #8175 (ab53cc0) into main (2b5fb55) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #8175      +/-   ##
==========================================
- Coverage   46.86%   46.85%   -0.01%     
==========================================
  Files         102      102              
  Lines       20384    20382       -2     
  Branches     4646     4646              
==========================================
- Hits         9552     9550       -2     
  Misses       9684     9684              
  Partials     1148     1148              
Impacted Files Coverage Δ
lib/ProductOpener/Tags.pm 53.61% <66.66%> (-0.06%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stephanegigandet stephanegigandet merged commit dc09be1 into main Mar 10, 2023
@stephanegigandet stephanegigandet deleted the remove-file-fetch branch March 10, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In production, some accents are broken with UTF8 sequences shown
3 participants