Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Barcode is not visible in the edit mode #7855

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

Sakshamgupta90
Copy link
Contributor

Screenshot

Screenshot 2022-12-16 at 8 24 17 PM

Related issue(s) and discussion

@Sakshamgupta90 Sakshamgupta90 requested a review from a team as a code owner December 16, 2022 14:55
@github-actions github-actions bot added ✏️ Editing Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. labels Dec 16, 2022
@Sakshamgupta90
Copy link
Contributor Author

Hi @stephanegigandet, sorry due to some issue the previous PR gets deleted. I have make the changes as you have said. :)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alexgarel alexgarel changed the title Solve issue #7786: Barcode is not visible in the edit mode. fix: Barcode is not visible in the edit mode Dec 19, 2022
@alexgarel
Copy link
Member

@Sakshamgupta90 small tip: pay attention to your PR titles.
We use conventional commit spec, with those possible prefixes:

fix
docs
style
refactor
test
build
ci
chore
revert
l10n
taxonomy

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @Sakshamgupta90 !

@alexgarel alexgarel merged commit edd435e into openfoodfacts:main Dec 19, 2022
@Sakshamgupta90
Copy link
Contributor Author

Hi @alexgarel, Thanks a lot and I will definitely keep in my mind this, sorry for that. One more thing, I have planned that first of all I will try to fix those issues which are related to the new Design. So should I proceed with it, or I should start contributing in some bugs and all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEW DESIGN: The barcode is not visible in edit mode
2 participants