Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Added the logo for the Label Bee Friendly #7360

Merged
merged 9 commits into from
Sep 27, 2022
Merged

chore: Added the logo for the Label Bee Friendly #7360

merged 9 commits into from
Sep 27, 2022

Conversation

pratyaksh1610
Copy link
Contributor

Related issue(s) and discussion

@pratyaksh1610 pratyaksh1610 requested a review from a team as a code owner September 17, 2022 07:18
@stephanegigandet
Copy link
Contributor

Could you rename the file to je-protege-les-abeilles.svg to je-protege-les-abeilles.90x90.svg and make the black background transparent? 90x90 indicates the aspect ratio.

@alexgarel
Copy link
Member

See #7231 (comment)

You have to add the label to the taxonomy, otherwise it won't be displayed.

alexgarel
alexgarel requested changes Sep 26, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank @pratyaksh1610
Still one fix to go :-)

taxonomies/labels.txt Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

alexgarel
alexgarel approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it worked 🎉
Thanks @pratyaksh1610

Note that it will only be seen after a taxonomy rebuild (which happens from time to time…).

@alexgarel alexgarel merged commit c005b3e into openfoodfacts:main Sep 27, 2022
@alexgarel alexgarel mentioned this pull request Sep 27, 2022
Merged
@pratyaksh1610 pratyaksh1610 deleted the logo-branch branch September 28, 2022 10:45
@manon-corneille
Copy link
Contributor

Hi guys, (cc @alexgarel)
It seems that the label Bee Friendly is not recognised yet → https://fr.openfoodfacts.org/label/bee-friendly
Is it related to the " taxonomy rebuild "?

Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@pratyaksh1610 pratyaksh1610

Labels
None yet
Projects
old prs
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the logo for the Label Bee Friendly
5 participants
@pratyaksh1610 @stephanegigandet @alexgarel @manon-corneille @teolemon