Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: create Pâtisson (squash) #7344

Merged
merged 4 commits into from
Sep 16, 2022
Merged

taxonomy: create Pâtisson (squash) #7344

merged 4 commits into from
Sep 16, 2022

Conversation

OpenChris
Copy link
Contributor

@OpenChris OpenChris commented Sep 15, 2022

• Create Pâtisson (squash) with Agribalyse proxy on Courge melonnette
• Create Echine de porc (Agribalyse 28302)
• Link Aiguillettes de canard to Duck breasts (vs Duck today) to give a better Agribalyse reference (Aiguillettes are a part of the Magret)
• Create Batavia type of salad and use Iceberg as an Abribalyse proxy (Iceberg is from the laitues pommées batavias family)

Agribalyse proxy on Courge melonnette
@github-actions github-actions bot added categories 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Sep 15, 2022
Gives a better Agribalyse reference (Aiguillettes are a part of the Magret)
use Iceberg as an Abribalyse proxy
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@@ -71372,6 +71372,12 @@ ciqual_food_code:en:28451
ciqual_food_name:en:Pork, loin, roasted/baked
ciqual_food_name:fr:Porc, échine, rôtie/cuite au four

<en:Pork meat
fr:échine de porc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be great to have an English translation. But it seems Ciqual used the same name for both 28302 and 28003.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it seems that the English language doesn't have a distinction between Longe de porc and Echine de porc. They both fall into the "loin" category. Or they call the Echine "spare ribs", which should really be the Travers de porc.

@OpenChris OpenChris merged commit 2e7f30a into main Sep 16, 2022
@OpenChris OpenChris deleted the openchris-taxonomies branch September 16, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants