Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: send set-cookie headers in redirects #7258

Merged
merged 1 commit into from
Aug 29, 2022
Merged

fix: send set-cookie headers in redirects #7258

merged 1 commit into from
Aug 29, 2022

Conversation

stephanegigandet
Copy link
Contributor

the session cookie was not sent in 302 redirects

This is needed in particular for Kratos auth: #7071

@stephanegigandet stephanegigandet requested a review from a team as a code owner August 26, 2022 13:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

alexgarel
alexgarel approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephanegigandet stephanegigandet merged commit 202070c into main Aug 29, 2022
@stephanegigandet stephanegigandet deleted the 302-set-cookie branch August 29, 2022 15:09
@alexgarel alexgarel mentioned this pull request Aug 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
Display
Projects
Product Opener - Sprint
Status: 👀 PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanegigandet @alexgarel