fix: add missing subdomain to redirect url #6993 #7019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
alexgarel
approved these changes
Jul 7, 2022
LandonPattison
pushed a commit
that referenced
this pull request
Jul 24, 2022
LandonPattison
pushed a commit
that referenced
this pull request
Jul 25, 2022
LandonPattison
pushed a commit
that referenced
this pull request
Jul 25, 2022
LandonPattison
pushed a commit
that referenced
this pull request
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue reported by @monsieurtanuki
When accessing URLs like https://world.openfoodfacts.org/informer/monsieurtanuki/state/to-be-completed.json?lc=fr --> the tags and tagtypes are translated to French, and we are redirected to:
https://world.openfoodfacts.org/informateur/monsieurtanuki/etat/a-completer.json
This works only is the subdomain is also changed.
Fixes #6993
Also helps openfoodfacts/smooth-app#2315 but those URLs are very tied to the website URLs, they are mostly for debugging purposes, apps should use the search API instead to get products matching facets.