Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: "edible" should be recognized as a stop word #6940

Merged
merged 2 commits into from
Jun 23, 2022
Merged

feat: "edible" should be recognized as a stop word #6940

merged 2 commits into from
Jun 23, 2022

Conversation

yuktea
Copy link
Contributor

@yuktea yuktea commented Jun 22, 2022 •
edited
Loading

What

This PR adds a unit test for checking the implemented fix and appends "edible" to the list of English "stopwords"

Observing in issue #6941, most of the unknown-tagged ingredients could be fixed if we ignore the word edible.

  • commit-1: Added a test that should break unless a fix is implemented. [Confirmed it breaks]
  • commit-2: Added edible to the list of English stopwords

Related issue(s) and discussion

@yuktea yuktea requested a review from a team as a code owner June 22, 2022 18:49
@yuktea yuktea changed the title test: "edible" should be recognized as a stop word feat: "edible" should be recognized as a stop word Jun 22, 2022
@yuktea
fix: add edible as a stopword
8a32ce1 
I've confirmed that the test in the last commit fails. This should make the test pass.
This change adds edible as a redundant word/something to be ignored.
@github-actions github-actions bot added 🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Jun 22, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

stephanegigandet
stephanegigandet approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stephanegigandet
Copy link
Contributor

I started a wiki page to track the quality of ingredients analysis in IN, UK and US, so that we can see how your changes impact the analysis: https://wiki.openfoodfacts.org/Ingredients_Analysis_Quality_Evaluation_-_June_2022

@stephanegigandet stephanegigandet merged commit 7082172 into main Jun 23, 2022
@stephanegigandet stephanegigandet deleted the edible-as-a-stopword branch June 23, 2022 07:59
@yuktea
Copy link
Contributor Author

yuktea commented Jun 23, 2022 •
edited
Loading

I started a wiki page to track the quality of ingredients analysis in IN, UK and US, so that we can see how your changes impact the analysis: https://wiki.openfoodfacts.org/Ingredients_Analysis_Quality_Evaluation_-_June_2022

Thank you, this sounds really good :)

@alexgarel alexgarel mentioned this pull request Jun 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@yuktea yuktea

Labels
🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
No open projects
Outreachy 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ingredients with prefix "edible" are unknown
2 participants
@yuktea @stephanegigandet