Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct unit for nutrients expressed in IU or %DV #6883

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

stephanegigandet
Copy link
Contributor

I made a mistake 6 months ago when removing nutrients from Food.pm to use the nutrients taxonomy instead, and the nutrients added with %DV (daily values) or IU (International Units) were not converted correctly to grams.

This fixes it and adds some tests.

Fixes #6882

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool that you added a test.

@alexgarel alexgarel merged commit 2e45a06 into main Jun 10, 2022
@alexgarel alexgarel deleted the iu-dv-units branch June 10, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nutrient values specified in %DV are not converted correctly
2 participants