fix: flatten Nutri-Score and Eco-Score SVG icons #6872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Nutri-Score and Eco-Score icons did not display correctly in Smoothie (probably an issue with how the flutter_svg package deals with clipPath and/or transforms).
See: openfoodfacts/smooth-app#2205
In order to solve the issue, the corresponding SVG icons were flattened (removing clipPath and transforms, so that the paths have absolute coordinates).
It's unfortunately not possible to do automatically through gulp-svg / SVGO:
The method that worked for me: