Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate and send GS1 CIC confirmation messages to Agena3000 #6756

Merged
merged 14 commits into from
May 17, 2022
Merged

feat: generate and send GS1 CIC confirmation messages to Agena3000 #6756

merged 14 commits into from
May 17, 2022

Conversation

stephanegigandet
Copy link
Contributor

Part of #6537

  • Parse the "message" part of GS1 messages (previously we ignored the message envelope and extracted only the product data)
  • Generate CIC XML confirmation messages
  • Added tests for the confirmation messages
  • Send back the confirmation messages to Agena3000

@stephanegigandet stephanegigandet added 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers GS1 The producer platform is integrating with the GS1 product data formats. GS1 manages barcodes. labels May 10, 2022
@stephanegigandet stephanegigandet requested a review from a team as a code owner May 10, 2022 15:21
@github-actions github-actions bot added Display Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests labels May 10, 2022
alexgarel
alexgarel approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just ask for a doc

lib/ProductOpener/GS1.pm
}


sub generate_gs1_confirmation_message($$) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A doc would be good, it's already quite complicated this gs1 stuff, so better document !

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stephanegigandet stephanegigandet merged commit b9b6f05 into main May 17, 2022
@stephanegigandet stephanegigandet deleted the agena3000-cic branch May 17, 2022 14:40
@alexgarel alexgarel mentioned this pull request May 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
Display GS1 The producer platform is integrating with the GS1 product data formats. GS1 manages barcodes. 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests
Projects
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanegigandet @alexgarel