feat: check {variables} are kept in translations

[stephanegigandet]

Related to #6702

This PR makes the tests fail if some translations removed some {variables}:

not ok 743 - f_app_user translation in uk contains {app_name}
#   Failed test 'f_app_user translation in uk contains {app_name}'
#   at lang.t line 91.
Wide character in print at /opt/perl/local/lib/perl5/Test2/Formatter/TAP.pm line 125.
#                   'Користувач додатку'
#     doesn't match '(?^u:\{app_name\})'
not ok 744 - f_energy_expenditure_for_weight_in_kg_lb translation in uk contains {kg}
#   Failed test 'f_energy_expenditure_for_weight_in_kg_lb translation in uk contains {kg}'
#   at lang.t line 91.
Wide character in print at /opt/perl/local/lib/perl5/Test2/Formatter/TAP.pm line 125.
#                   'Використання енергії для людини вагою кг/ фунт'
#     doesn't match '(?^u:\{kg\})'
not ok 745 - f_energy_expenditure_for_weight_in_kg_lb translation in uk contains {lb}
#   Failed test 'f_energy_expenditure_for_weight_in_kg_lb translation in uk contains {lb}'
#   at lang.t line 91.
Wide character in print at /opt/perl/local/lib/perl5/Test2/Formatter/TAP.pm line 125.
#                   'Використання енергії для людини вагою кг/ фунт'
#     doesn't match '(?^u:\{lb\})'
not ok 746 - f_nova_markers_for_nova_group translation in es contains {nova_group}
#   Failed test 'f_nova_markers_for_nova_group translation in es contains {nova_group}'
#   at lang.t line 91.
#                   'Elementos que indican que el producto se encuentra en el grupo(nova_group)'
#     doesn't match '(?^u:\{nova_group\})'
Use of uninitialized value in pattern match (m//) at lang.t line 85.
en: Elements that indicate the product is in the {nova_group} group
es: Elementos que indican que el producto se encuentra en el grupo(nova_group)
1..746
# Looks like you failed 4 tests of 746.

[teolemon]

I've made fixes in crowdin. Changes should sync tomorrow

[alexgarel]

LGTM

[alexgarel]

Those two lines should be removed ?

[stephanegigandet]

Yes, good catch, I removed them.

[alexgarel]

@teolemon still got:

2022-04-28T09:05:25.9846907Z #                   'Bu hesap üretici veya marka(org). ile ilişkili profesyonel bir hesaptır. Üreticiler için olan Platforma erişiminiz vardır.'
2022-04-28T09:05:25.9847332Z #     doesn't match '(?^u:\{org\})'

[alexgarel]

Could'nt help it 😬

[teolemon]

thanks @alexgarel, fixed in crowdin

[alexgarel]

still failing after crowdin merge @teolemon !

@stephanegigandet do the script reports all problems, or just part of them ?

2022-04-29T08:18:26.0939365Z 
2022-04-29T08:18:26.0939823Z #   Failed test 'f_move_data_and_photos_to_main_language translation in tr contains {language}'
2022-04-29T08:18:26.0940137Z #   at t/lang.t line 91.
2022-04-29T08:18:26.0940444Z Wide character in print at /opt/perl/local/lib/perl5/Test2/Formatter/TAP.pm line 125.
2022-04-29T08:18:26.0941066Z #                   '(dilindeki) seçilen fotoğrafları ve tüm verileri ürünün ana diline yerleştirin(ana dil)'
2022-04-29T08:18:26.0941462Z #     doesn't match '(?^u:\{language\})'
2022-04-29T08:18:26.0941618Z 
2022-04-29T08:18:26.0941913Z #   Failed test 'f_move_data_and_photos_to_main_language translation in tr contains {main_language}'
2022-04-29T08:18:26.0942238Z #   at t/lang.t line 91.
2022-04-29T08:18:26.0942549Z Wide character in print at /opt/perl/local/lib/perl5/Test2/Formatter/TAP.pm line 125.
2022-04-29T08:18:26.0943082Z #                   '(dilindeki) seçilen fotoğrafları ve tüm verileri ürünün ana diline yerleştirin(ana dil)'
2022-04-29T08:18:26.0943468Z #     doesn't match '(?^u:\{main_language\})'
2022-04-29T08:18:26.0943780Z Use of uninitialized value in pattern match (m//) at t/lang.t line 85.

[stephanegigandet]

@stephanegigandet do the script reports all problems, or just part of them ?

all of them

[alexgarel]

I fixed the problem on a Turkish string (in the file and in crowdin) to be able to merge this PR.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information