Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for 2 GS1 quantityContained field in nutrientDetail #6630

Merged
merged 1 commit into from
Apr 22, 2022
Merged

feat: add support for 2 GS1 quantityContained field in nutrientDetail #6630

merged 1 commit into from
Apr 22, 2022

Conversation

stephanegigandet
Copy link
Contributor

part of #6537

needed as Equadis and Agena3000 have different ways of passing the values for energy in both kj and kcal

@stephanegigandet stephanegigandet requested a review from a team as a code owner April 15, 2022 14:21
@github-actions github-actions bot added GS1 The producer platform is integrating with the GS1 product data formats. GS1 manages barcodes. 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers 🧪 tests labels Apr 15, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

alexgarel
alexgarel approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stephanegigandet stephanegigandet merged commit f6c2678 into main Apr 22, 2022
@stephanegigandet stephanegigandet deleted the agena3000-energy2 branch April 22, 2022 13:22
@alexgarel alexgarel mentioned this pull request Apr 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees
No one assigned
Labels
GS1 The producer platform is integrating with the GS1 product data formats. GS1 manages barcodes. 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers 🧪 tests
Projects
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanegigandet @alexgarel