fix: Add tests for Carrefour France import, + solve serving_size bug #6476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Data import
export
🏭 Producers Platform
stephanegigandet
changed the title
alexgarel
reviewed
Mar 9, 2022
| ProductOpener::Test::compare_csv_file_to_expected_results($exported_csv_file, $test_dir . "/expected_test_results/import_convert_carrefour_france_export", $update_expected_results); | ||
|
|
||
|
|
||
| done_testing(); |
There was a problem hiding this comment.
Really cool to have simple integrations tests like this.
alexgarel
requested changes
Mar 9, 2022
There was a problem hiding this comment.
I think you forgot to add ImportConvertCarrefourFrance.pm @stephanegigandet !
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a long standing issue #2973 that results in almost daily changes being made to some products imported by Carrefour France. The corresponding input files in fact did not change, but we were mapping multiple values (for different languages) to the same field: the values were concatenated, but in a not specified order. So the values changed.
This PR:
Note: in order to be able to create a test, most of the code from convert_carrefour_data.pl was moved to a new ImportConvertCarrefourFrance.pm module, but no attempt was made to improve that code.