Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flagr segments evaluation should stop if it matches all the constraints in a segment #180

Closed
zhouzhuojie opened this issue Oct 22, 2018 · 0 comments · Fixed by #181
Closed
Assignees

Comments

@zhouzhuojie
Copy link
Collaborator

Expected Behavior

If the entity context matches the constraints in a segment, it should stop evaluating the following segments.

Specifically, for 0% rollout segment, it shouldn't go to the next segments.

For example:

image

The first segment catches all the entity, and roll out to 0%, so every entity should have null variant returned.

Current Behavior

It falls through to the next segment for non-rolled out users in the previous segments.

image

Possible Solution

Stop evaluating the next segments if we found a match (i.e. satisfied all the constraints in a segment)

Steps to Reproduce (for bugs)

https://try-flagr.herokuapp.com/#/flags/1

@zhouzhuojie zhouzhuojie self-assigned this Oct 22, 2018
@zhouzhuojie zhouzhuojie changed the title Flagr segments evaluation should stop if it match all the constraints in a segment Flagr segments evaluation should stop if it matches all the constraints in a segment Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant