Commit 70cfa19
authored
fix: migrate transaction docs and examples to transactions() API (#373)
* fix: migrate transaction docs and examples to transactions() API
Move the write mode-selection Javadoc in OpenFgaClient and the example
projects off the double-negative disableTransactions(boolean) to the
affirmative transactions()/isTransactionsEnabled() API. Also switch the
internal write mode branch to !isTransactionsEnabled() so the SDK no longer
calls its own soon-to-be-deprecated method. Behavior is unchanged.
Test call sites that still use disableTransactions are intentionally left
for the deprecation issue, which will migrate them and keep one back-compat
test under @SuppressWarnings.
Refs #368
* fix: clarify write mode Javadoc for the no-options overload
Address review feedback. The write(request) overload takes no options, so
describing the mode as options.isTransactionsEnabled() implied a call on an
absent or null options reference. Reword both overloads to key the mode off
the transactions() setter and state that transactional mode is the default
when no options are passed.
Docs only, no behavior change.
Refs #3681 parent ed63320 commit 70cfa19
4 files changed
Lines changed: 8 additions & 8 deletions
File tree
- examples/basic-examples/src/main
- java/dev/openfga/sdk/example
- kotlin/dev/openfga/sdk/example
- src
- main/java/dev/openfga/sdk/api/client
- test-integration/java/dev/openfga/sdk/example
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
120 | | - | |
| 120 | + | |
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
120 | | - | |
| 120 | + | |
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
| |||
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
412 | 412 | | |
413 | 413 | | |
414 | 414 | | |
415 | | - | |
| 415 | + | |
416 | 416 | | |
417 | 417 | | |
418 | 418 | | |
| |||
421 | 421 | | |
422 | 422 | | |
423 | 423 | | |
424 | | - | |
| 424 | + | |
425 | 425 | | |
426 | 426 | | |
427 | 427 | | |
| |||
466 | 466 | | |
467 | 467 | | |
468 | 468 | | |
469 | | - | |
| 469 | + | |
470 | 470 | | |
471 | 471 | | |
472 | 472 | | |
| |||
475 | 475 | | |
476 | 476 | | |
477 | 477 | | |
478 | | - | |
| 478 | + | |
479 | 479 | | |
480 | 480 | | |
481 | 481 | | |
| |||
515 | 515 | | |
516 | 516 | | |
517 | 517 | | |
518 | | - | |
| 518 | + | |
519 | 519 | | |
520 | 520 | | |
521 | 521 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
120 | | - | |
| 120 | + | |
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
| |||
0 commit comments