Conversation
tomusdrw
added
A0-pleasereview 🤓
|
Shouldn't we remove the |
|
@tomaka It's still useful - allows to share the log format between main parity binary and whisper CLI + exposes latest logs via RPC method. None of this is super critical, so I guess we could remove it entirely (and integrate the setup with the main crate) if you believe it's the way to go. |
I think this is the way to go, but we can do it later. |
|
Note that if we're really in the path to remove |
| #[test] | ||
| fn document_key_generation_and_retrievement_works_over_network_with_single_node() { | ||
| //::logger::init_log(); | ||
| //::env_logger::try_init(); |
There was a problem hiding this comment.
Not caused by this PR, but can we remove those lines as they are commented out? Or just uncomment it, because it's try_init and might break individual test invoking.
|
I've removed So now it's only required by |
| #[test] | ||
| fn document_key_generation_and_retrievement_works_over_network_with_3_nodes() { | ||
| //::logger::init_log(); | ||
| ::env_logger::try_init().ok(); |
There was a problem hiding this comment.
Maybe let _ = ::env_logger::try_init();?
| #[test] | ||
| fn error_in_generation_session_broadcasted_to_all_other_nodes() { | ||
| //::logger::init_log(); | ||
| //::env_logger::try_init(); |
There was a problem hiding this comment.
And uncomment those as well!
|
Regarding the deprecation, should this be logged somewhere so it's not forgotten? |
|
Thanks. Could you resolve the conflicts? |
5chdn
added
A8-looksgood 🦄
|
I was brought here by the RPC method |
8 participants
env_loggeris sufficient and we can avoid bringing additional path dependency.