Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Deduplicate smallvec dependency #9558

Closed
ordian opened this issue Sep 14, 2018 · 2 comments
Closed

Deduplicate smallvec dependency #9558

ordian opened this issue Sep 14, 2018 · 2 comments
Labels
F7-footprint 🐾 An enhancement to provide a smaller (system load, memory, network or disk) footprint. P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Milestone

Comments

@ordian
Copy link
Collaborator

ordian commented Sep 14, 2018

Currently we have several versions of the same (transitive) dependency, e.g.:

smallvec v0.2.1
smallvec v0.4.5
smallvec v0.6.5

It would be nice to remove duplicates, which in turn will reduce compile time and maybe binary size.
To see the list of dependencies, run: cargo tree --no-indent | sort | rg -v "\(\*\)$" | uniq

@ordian ordian added P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. M5-dependencies 🖇 Dependencies. F7-footprint 🐾 An enhancement to provide a smaller (system load, memory, network or disk) footprint. and removed M5-dependencies 🖇 Dependencies. labels Sep 14, 2018
@5chdn 5chdn added this to the 2.3 milestone Sep 14, 2018
@debris
Copy link
Collaborator

debris commented Sep 17, 2018

I don't think we should have a generic issue for all duplicate dependencies in parity. It should be a policy to avoid them, but with so many of them, the duplication is sometimes inevitable

@debris debris changed the title Deduplicate dependencies Deduplicate smallvec dependency Sep 17, 2018
@ordian ordian mentioned this issue Oct 2, 2018
1 task
@5chdn 5chdn modified the milestones: 2.3, 2.4 Oct 29, 2018
@ordian
Copy link
Collaborator Author

ordian commented Oct 30, 2018

closed by #9657

@ordian ordian closed this as completed Oct 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F7-footprint 🐾 An enhancement to provide a smaller (system load, memory, network or disk) footprint. P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Development

No branches or pull requests

3 participants