From 588881a98f91d23efbeee6a2ccbf2c1b0559e1e6 Mon Sep 17 00:00:00 2001
From: Mattia Basaglia <mattia@opencraft.com>
Date: Wed, 9 Jun 2021 18:43:54 +0200
Subject: [PATCH] fix: Handle None in course breadcrumbs

Under some circumstances sequence_title might be None,
which causes the breadcrumbs to display "None".

This ensures that doesn't happen and avoids stray breadcrumb
separators.
---
 lms/templates/courseware/courseware.html | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/lms/templates/courseware/courseware.html b/lms/templates/courseware/courseware.html
index 2e53b5611aec..9737682f9ca8 100644
--- a/lms/templates/courseware/courseware.html
+++ b/lms/templates/courseware/courseware.html
@@ -181,21 +181,29 @@
                                 <span class="nav-item nav-item-course">
                                     <a href="${course_url}">${course_home_page_title(course)}</a>
                                 </span>
-                                <span class="icon fa fa-angle-right" aria-hidden="true"></span>
+                                % if chapter or section or sequence_title:
+                                    <span class="icon fa fa-angle-right" aria-hidden="true"></span>
+                                % endif
                             % endif
                             % if chapter:
                                 <span class="nav-item nav-item-chapter" data-course-position="${course.position}" data-chapter-position="${chapter.position}">
                                     <a href="${course_url}#${six.text_type(chapter.location)}">${chapter.display_name_with_default}</a>
                                 </span>
-                                <span class="icon fa fa-angle-right" aria-hidden="true"></span>
+                                % if section or sequence_title:
+                                    <span class="icon fa fa-angle-right" aria-hidden="true"></span>
+                                % endif
                             % endif
                             % if section:
                                 <span class="nav-item nav-item-section">
                                     <a href="${course_url}#${six.text_type(section.location)}">${section.display_name_with_default}</a>
                                 </span>
-                                <span class="icon fa fa-angle-right" aria-hidden="true"></span>
+                                % if sequence_title:
+                                    <span class="icon fa fa-angle-right" aria-hidden="true"></span>
+                                % endif
+                            % endif
+                            % if sequence_title:
+                                <span class="nav-item nav-item-sequence">${sequence_title}</span>
                             % endif
-                            <span class="nav-item nav-item-sequence">${sequence_title}</span>
                         </div>
                     </div>
                 </nav>