Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct typos in localization keys, comments, and button labels #500

Merged
merged 4 commits into from
Jul 25, 2024
Merged

fix: correct typos in localization keys, comments, and button labels #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
05d3073
Merge pull request #281 from openedx/develop
volodymyr-chekyrta Feb 12, 2024
64b1c0e
Merge pull request #413 from openedx/develop
volodymyr-chekyrta Apr 22, 2024
7b9010c
Merge pull request #424 from openedx/develop
volodymyr-chekyrta May 6, 2024
3f34991
fix: correct typos in localization keys, comments, and button labels
milad-emami Jul 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Core/Core/View/Base/AlertView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ struct AlertView_Previews: PreviewProvider {
.previewLayout(.sizeThatFits)
.background(Color.gray)

AlertView(alertTitle: "Comfirm log out",
AlertView(alertTitle: "Confirm log out",
alertMessage: "Are you sure you want to log out?",
positiveAction: "Yes",
onCloseTapped: {},
Expand Down
4 changes: 2 additions & 2 deletions Profile/Profile/Presentation/DeleteAccount/DeleteAccountView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,15 +99,15 @@ public struct DeleteAccountView: View {
maxWidth: .infinity,
alignment: .topLeading)

// MARK: Comfirmation button
// MARK: Confirmation button
if viewModel.isShowProgress {
ProgressBar(size: 40, lineWidth: 8)
.padding(.top, 20)
.padding(.horizontal)
.accessibilityIdentifier("progressbar")
} else {
StyledButton(
ProfileLocalization.DeleteAccount.comfirm,
ProfileLocalization.DeleteAccount.confirm,
action: {
Task {
try await viewModel.deleteAccount(password: viewModel.password)
Expand Down
6 changes: 3 additions & 3 deletions Profile/Profile/SwiftGen/Strings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public enum ProfileLocalization {
/// Back to profile
public static let backToProfile = ProfileLocalization.tr("Localizable", "DELETE_ACCOUNT.BACK_TO_PROFILE", fallback: "Back to profile")
/// Yes, delete account
public static let comfirm = ProfileLocalization.tr("Localizable", "DELETE_ACCOUNT.COMFIRM", fallback: "Yes, delete account")
public static let confirm = ProfileLocalization.tr("Localizable", "DELETE_ACCOUNT.CONFIRM", fallback: "Yes, delete account")
/// To confirm this action, please enter your account password.
public static let description = ProfileLocalization.tr("Localizable", "DELETE_ACCOUNT.DESCRIPTION", fallback: "To confirm this action, please enter your account password.")
/// The password is incorrect. Please try again.
Expand Down Expand Up @@ -110,8 +110,8 @@ public enum ProfileLocalization {
public enum LogoutAlert {
/// Are you sure you want to log out?
public static let text = ProfileLocalization.tr("Localizable", "LOGOUT_ALERT.TEXT", fallback: "Are you sure you want to log out?")
/// Comfirm log out
public static let title = ProfileLocalization.tr("Localizable", "LOGOUT_ALERT.TITLE", fallback: "Comfirm log out")
/// Confirm log out
public static let title = ProfileLocalization.tr("Localizable", "LOGOUT_ALERT.TITLE", fallback: "Confirm log out")
}
public enum Settings {
/// Lower data usage
Expand Down
4 changes: 2 additions & 2 deletions Profile/Profile/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"FULL_PROFILE" = "full profile";
"LIMITED_PROFILE" = "limited profile";

"LOGOUT_ALERT.TITLE" = "Comfirm log out";
"LOGOUT_ALERT.TITLE" = "Confirm log out";
"LOGOUT_ALERT.TEXT" = "Are you sure you want to log out?";

"DELETE_ALERT.TITLE" = "Warning!";
Expand Down Expand Up @@ -55,7 +55,7 @@
"DELETE_ACCOUNT.DESCRIPTION" = "To confirm this action, please enter your account password.";
"DELETE_ACCOUNT.PASSWORD" = "Password";
"DELETE_ACCOUNT.PASSWORD_DESCRIPTION" = "Enter password";
"DELETE_ACCOUNT.COMFIRM" = "Yes, delete account";
"DELETE_ACCOUNT.CONFIRM" = "Yes, delete account";
"DELETE_ACCOUNT.BACK_TO_PROFILE" = "Back to profile";
"DELETE_ACCOUNT.INCORRECT_PASSWORD" = "The password is incorrect. Please try again.";

Expand Down
2 changes: 1 addition & 1 deletion Profile/Profile/uk.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"DELETE_ACCOUNT.DESCRIPTION" = "Для підтвердження цієї дії необхідно ввести пароль свого облікового запису.";
"DELETE_ACCOUNT.PASSWORD" = "Пароль";
"DELETE_ACCOUNT.PASSWORD_DESCRIPTION" = "Введіть пароль";
"DELETE_ACCOUNT.COMFIRM" = "Так, видалити акаунт";
"DELETE_ACCOUNT.CONFIRM" = "Так, видалити акаунт";
"DELETE_ACCOUNT.BACK_TO_PROFILE" = "Повернутись до профілю";
"DELETE_ACCOUNT.INCORRECT_PASSWORD" = "Пароль неправильний. Будь ласка спробуйте ще раз.";

Expand Down
Loading