Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct typos in localization keys, comments, and button labels #500

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

milad-emami
Copy link
Contributor

Corrected spelling mistakes in various localization keys, comments, and button labels.

  • Changed 'Comfirm' to 'Confirm' in alert titles and confirmations
  • Updated localization keys:
    • 'LOGOUT_ALERT.TITLE'
    • 'DELETE_ACCOUNT.CONFIRM'
  • Fixed spelling in StyledButton calls and localization fallback text
  • Updated the Ukrainian translation for DELETE_ACCOUNT.CONFIRM
  • Corrected comments in the codebase

These changes improve clarity and maintain consistency across the codebase.

volodymyr-chekyrta and others added 4 commits February 12, 2024 09:36
Corrected spelling mistakes in various localization keys, comments, and button labels.

- Changed 'Comfirm' to 'Confirm' in alert titles and confirmations
- Updated localization keys:
  - 'LOGOUT_ALERT.TITLE'
  - 'DELETE_ACCOUNT.CONFIRM'
- Fixed spelling in StyledButton calls and localization fallback text
- Updated the Ukrainian translation for DELETE_ACCOUNT.CONFIRM
- Corrected comments in the codebase

These changes improve clarity and maintain consistency across the codebase.
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 13, 2024

Thanks for the pull request, @milad-emami!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-mobile-maintainers. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 13, 2024
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 16, 2024
@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 24, 2024
@mphilbrick211 mphilbrick211 requested a review from a team July 24, 2024 21:22
@volodymyr-chekyrta volodymyr-chekyrta changed the base branch from main to develop July 25, 2024 07:49
Copy link
Contributor

@volodymyr-chekyrta volodymyr-chekyrta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@volodymyr-chekyrta volodymyr-chekyrta merged commit c291b50 into openedx:develop Jul 25, 2024
3 checks passed
@openedx-webhooks
Copy link

@milad-emami 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@volodymyr-chekyrta
Copy link
Contributor

@milad-emami, thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants