Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings button for dashboard type 'list' #479

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

rnr
Copy link
Contributor

@rnr rnr commented Jul 5, 2024

This PR fixes issue #468 where Settings button is missed for Dashboard type "list"
After fix:

iPhone iPad

@rnr rnr linked an issue Jul 5, 2024 that may be closed by this pull request
Copy link
Contributor

@volodymyr-chekyrta volodymyr-chekyrta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@saeedbashir saeedbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rnr rnr merged commit 15d2ed3 into openedx:develop Jul 8, 2024
3 checks passed
@rnr rnr deleted the setting-button-on-dashboard-list branch July 8, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] There is no "Settings" icon on Dashboard tab
3 participants