Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Calendar deep link to course component #381

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

shafqat-muneer
Copy link
Contributor

@shafqat-muneer shafqat-muneer commented Mar 29, 2024

LEARNER-9888: Navigate to a particular course component upon tapping the link from the native calendar application synced with the calendar for that specific course.

Demo:

RPReplay_Final1712047322-Compressed.mov

@eyatsenkoperpetio
Copy link
Contributor

@shafqat-muneer can you open full flow to this component?

for example, open from push:
https://github.com/openedx/openedx-app-ios/assets/76485998/f237be3d-b671-4cfa-83c1-d8c9b461160d

@shafqat-muneer
Copy link
Contributor Author

@shafqat-muneer can you open full flow to this component?

for example, open from push: https://github.com/openedx/openedx-app-ios/assets/76485998/f237be3d-b671-4cfa-83c1-d8c9b461160d

@eyatsenkoperpetio This flow will execute from native calendar link which is demoed in this video. Do you have any scenario in which it can execute through push notification?

@volodymyr-chekyrta
Copy link
Contributor

@shafqat-muneer can you open full flow to this component?
for example, open from push: https://github.com/openedx/openedx-app-ios/assets/76485998/f237be3d-b671-4cfa-83c1-d8c9b461160d

@eyatsenkoperpetio This flow will execute from native calendar link which is demoed in this video. Do you have any scenario in which it can execute through push notification?

@shafqat-muneer, I believe @eyatsenkoperpetio didn't mean to open that from a push notification, we probably need to open the full user path
MainView -> Course -> Course Sequential (Optional) -> xBlock
instead of
MainView -> xBlock
as @eyatsenkoperpetio demonstrated on video for deep links from pushes.

I think this is the right way too. If we give users the full path, they can just hit the back button to return to the course and keep learning with the next or previous section.

@shafqat-muneer
Copy link
Contributor Author

@volodymyr-chekyrta It appears I misunderstood. Thank you for providing clarification.
@eyatsenkoperpetio I'll adjust accordingly based on that.

@shafqat-muneer
Copy link
Contributor Author

@eyatsenkoperpetio I have completed the changes and have also included an updated demo video in the description of the PR. Please review it.

@shafqat-muneer shafqat-muneer removed the request for review from eyatsenkoperpetio April 3, 2024 11:30
@shafqat-muneer shafqat-muneer merged commit 0f00f73 into openedx:develop Apr 3, 2024
3 checks passed
@shafqat-muneer shafqat-muneer deleted the Shafqat/LEARNER-9888 branch April 3, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants