fix: There are no titles for "back menu" items #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyatsenkoperpetio
requested review from
rnr,
saeedbashir and
volodymyr-chekyrta
|
@eyatsenkoperpetio We are using custom navigation bar at some places; is it possible to mimic the save behavior there as well so the whole app behaves the same way on long press. Screen.Recording.2024-03-28.at.10.18.48.AM.mov |
rnr
approved these changes
Mar 28, 2024
|
@saeedbashir @sergeymomot we need create new enhancement issue for custom navigation bar |
volodymyr-chekyrta
approved these changes
Mar 28, 2024
It would be nice if we create that task and then merge it so it will be on track. |
saeedbashir
approved these changes
Mar 29, 2024
|
Created issue for custom nav bar #382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long pressing the Back button brings up a menu for selecting the back jump point. There are no titles for this menu items in our app
There are no titles for "back menu" items #349