Fix for the alignment of the "Back to profile" button #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnr
changed the title
saeedbashir
requested changes
Mar 15, 2024
There was a problem hiding this comment.
@rnr Please switch the button styles i.e the Yes, delete account will be a filled button (primary button style) and Back to profile will be with clear bg.
Oh, it was already discussed here #315 (comment) |
volodymyr-chekyrta
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for 325 Issue
As @sdaitzman suggested, the "Back to Profile" button uses the basic button style. The "Delete Account" button uses the red error/danger colour to highlight which action is destructive.
Also,
StyledButton Viewcan now have aniconimage. The icon can be placed to theleftorrightof the button title text.Inactive delete button:
Active delete button: