[iOS] "Post" button is almost invisible in active state for Discussions #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[iOS] "Post" button is almost invisible in active state for Discussions openedx#328
forgotvas
force-pushed
the
fix/post-button
branch
from
be13ac4 to
185bf4f
Compare
rnr
previously approved these changes
Mar 13, 2024
volodymyr-chekyrta
previously approved these changes
Mar 15, 2024
saeedbashir
reviewed
Mar 18, 2024
| : CoreAssets.sendDisabled.swiftUIImage | ||
| CoreAssets.send.swiftUIImage | ||
| .renderingMode(.template) | ||
| .foregroundStyle(Theme.Colors.accentColor) |
There was a problem hiding this comment.
It's an action button so it would be nice if you can use accentXColor here.
saeedbashir
approved these changes
Mar 18, 2024
rnr
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[iOS] "Post" button is almost invisible in active state for Discussions #328
Edx scheme:
OpenEdx scheme: