Firebase and Segment integration #291
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // | ||
| // SegmentConfig.swift | ||
| // Core | ||
| // | ||
| // Created by Anton Yarmolenka on 02/02/2024. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| private enum SegmentKeys: String, RawStringExtractable { | ||
| case enabled = "ENABLED" | ||
| case writeKey = "SEGMENT_IO_WRITE_KEY" | ||
| } | ||
|
|
||
| public final class SegmentConfig: NSObject { | ||
| public var enabled: Bool = false | ||
| public var writeKey: String = "" | ||
|
|
||
| init(dictionary: [String: AnyObject]) { | ||
| super.init() | ||
| enabled = dictionary[SegmentKeys.enabled] as? Bool == true | ||
| writeKey = dictionary[SegmentKeys.writeKey] as? String ?? "" | ||
|
There was a problem hiding this comment. Let's make |
||
| } | ||
| } | ||
|
|
||
| private let segmentKey = "SEGMENT_IO" | ||
| extension Config { | ||
| public var segment: SegmentConfig { | ||
| SegmentConfig(dictionary: self[segmentKey] as? [String: AnyObject] ?? [:]) | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about moving the
analytics.identify(.....)call toshowMainOrWhatsNewScreenso you don't have to worry about from where the main screen is being shown? At the moment it's being called from multiple places.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like the idea of passing User variable inside the router. However, we may come back to this question when we work with analytics (this is not part of this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok