feat: Don't delete downloaded videos when the user logs out #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyatsenkoperpetio
requested review from
rnr,
saeedbashir and
volodymyr-chekyrta
This was
linked to
issues
Feb 20, 2024
eyatsenkoperpetio
changed the title
rnr
previously approved these changes
Feb 20, 2024
| @@ -71,8 +71,8 @@ public class ProfileRepository: ProfileRepositoryProtocol { | |||
| ProfileEndpoint.logOut(refreshToken: refreshToken, clientID: config.oAuthClientId) | |||
| ) | |||
| storage.clear() | |||
| await downloadManager.deleteAllFiles() | |||
| coreDataHandler.clear() | |||
| //await downloadManager.deleteAllFiles() | |||
There was a problem hiding this comment.
do we need these commented out lines?
saeedbashir
reviewed
Feb 22, 2024
| await downloadManager.deleteAllFiles() | ||
| coreDataHandler.clear() | ||
| //await downloadManager.deleteAllFiles() | ||
| //coreDataHandler.clear() |
There was a problem hiding this comment.
@eyatsenkoperpetio Do we need to keep this as well if we want to keep downloaded files?
forgotvas
approved these changes
Feb 22, 2024
rnr
approved these changes
Feb 22, 2024
volodymyr-chekyrta
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user logs out, the downloaded content should not be deleted, so that when the user logs in again, all downloaded content will be available to him again.
For each user, only their downloaded content should be displayed.