Improvements for Download videos #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyatsenkoperpetio
requested review from
rnr,
saeedbashir and
volodymyr-chekyrta
This was
linked to
issues
Feb 8, 2024
rnr
previously approved these changes
Feb 8, 2024
saeedbashir
reviewed
Feb 12, 2024
Comment on lines
18
to
25
| public struct CircleProgressView: View { | ||
| public init () { | ||
| } | ||
|
|
||
| public var body: some View { | ||
| ProgressBar(size: 30, lineWidth: 1.75) | ||
| } | ||
| } |
There was a problem hiding this comment.
The ProgressBar itself is circular, then why its needed to define it again? Can't we use it directly, like we are using it in the whole codebase?
volodymyr-chekyrta
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements for Download videos functionality #251
Create an alert about the deletion of a downloaded video #264
Add an alert when a downloaded video is deleted #265
Screen.Recording.2024-02-08.at.12.51.58.mov