-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enrolled Web Based Programs Implementation #260
feat: Enrolled Web Based Programs Implementation #260
Conversation
@rnr Replying to your comments here as I've closed the other PR.
I gave it a thought and also discussed it with the team.
This will make it a bit hard to maintain it, like we have to maintain it on new and old apps and it will also not fix the issue on the mobile browsers. We will create a ticket for the web team to fix it so that the problem will be fixed for all small screens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@volodymyr-chekyrta Could you please spare some time and review it thanks. |
Discovery/Discovery/Presentation/WebPrograms/ProgramWebviewViewModel.swift
Outdated
Show resolved
Hide resolved
Discovery/Discovery/Presentation/WebPrograms/ProgramWebviewViewModel.swift
Outdated
Show resolved
Hide resolved
Let's merge it after the tests pass |
This PR adds support for web-based enrolled programs.
[iOS] Program Progress Page
programs.mov