Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enrolled Web Based Programs Implementation #260

Merged
merged 8 commits into from
Feb 2, 2024

Conversation

saeedbashir
Copy link
Contributor

This PR adds support for web-based enrolled programs.

[iOS] Program Progress Page

programs.mov

@saeedbashir
Copy link
Contributor Author

@rnr Replying to your comments here as I've closed the other PR.

@saeedbashir If Discovery Config now contains both Discovery and Program config, perhaps we need to rename it to some "level up" entry. Thoughts?

I gave it a thought and also discussed it with the team. DiscoveryConfig is the more suitable name that can represent both features as 70% of programs are also discover. If you have a name on you mind please let me know.

@saeedbashir I know it's webView based content but perhaps we can add a small css injection to add some left padding?

This will make it a bit hard to maintain it, like we have to maintain it on new and old apps and it will also not fix the issue on the mobile browsers. We will create a ticket for the web team to fix it so that the problem will be fixed for all small screens.

@miankhalid miankhalid linked an issue Jan 29, 2024 that may be closed by this pull request
rnr
rnr previously approved these changes Jan 29, 2024
shafqat-muneer
shafqat-muneer previously approved these changes Jan 31, 2024
Copy link
Contributor

@shafqat-muneer shafqat-muneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saeedbashir
Copy link
Contributor Author

@volodymyr-chekyrta Could you please spare some time and review it thanks.

@saeedbashir saeedbashir dismissed stale reviews from shafqat-muneer and rnr via 4b20448 February 2, 2024 11:41
@volodymyr-chekyrta
Copy link
Contributor

Let's merge it after the tests pass

@volodymyr-chekyrta volodymyr-chekyrta merged commit a03bb3e into openedx:develop Feb 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Program Progress Page
4 participants