Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/survey and dd #218

Merged
merged 12 commits into from
Jan 16, 2024
Merged

Feat/survey and dd #218

merged 12 commits into from
Jan 16, 2024

Conversation

forgotvas
Copy link
Contributor

That PR contains:

  • [iOS] Survey content [iOS] Survey content #174
  • [iOS] Drag and Drop Content [iOS] Drag and Drop Content #178
  • Webview injection pattern to inject css and JS scripts into HTML pages or requests
  • Drag And Drop CSS injection to fix bug with text selection
  • Survey CSS injection to fix issue with survey content representation

Previews:

Survey:

Simulator Screenshot - iPhone 15 - 2024-01-04 at 15 19 14 thumbnail

Simulator Screenshot - iPhone 15 - 2024-01-04 at 15 19 51 thumbnail

Drag and Drop:

Simulator.Screen.Recording.-.iPhone.15.-.2024-01-04.at.15.21.23.mp4

This was linked to issues Jan 8, 2024
[iOS] Survey content #174
Closed
[iOS] Drag and Drop Content #178
Closed
@forgotvas forgotvas requested a review from rnr January 12, 2024 11:07
saeedbashir
saeedbashir approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@saeedbashir saeedbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@forgotvas forgotvas merged commit 8bac9c7 into openedx:develop Jan 16, 2024
3 checks passed
@forgotvas forgotvas deleted the feat/surveyAndDD branch January 16, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-chekyrta volodymyr-chekyrta volodymyr-chekyrta approved these changes

@saeedbashir saeedbashir saeedbashir approved these changes

@rnr rnr rnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] Drag and Drop Content [iOS] Survey content
4 participants
@forgotvas @rnr @saeedbashir @volodymyr-chekyrta