Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add landscape mode support #102

Merged
merged 9 commits into from
Oct 16, 2023
Merged

Add landscape mode support #102

merged 9 commits into from
Oct 16, 2023

Conversation

IvanStepanok
Copy link
Contributor

Screen.Recording.2023-10-10.at.16.38.17.1.mp4

@volodymyr-chekyrta volodymyr-chekyrta linked an issue Oct 11, 2023 that may be closed by this pull request
Landscape support #90
Closed
@sdaitzman
Copy link

This looks great! I added some slight proposed design changes to the matching PR for Android: openedx/openedx-app-android#68 (comment)

@IvanStepanok
Copy link
Contributor Author

IvanStepanok commented Oct 13, 2023 •
edited
Loading

@sdaitzman Hello there! Design changes:

Simulator Screenshot - iPhone 15 Pro - 2023-10-13 at 11 44 56

Simulator Screenshot - iPhone 15 Pro - 2023-10-13 at 11 26 55

Simulator Screenshot - iPhone 15 Pro - 2023-10-13 at 14 30 44

Simulator Screenshot - iPhone 15 Pro - 2023-10-13 at 14 30 12

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 13, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @IvanStepanok! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Stepanokdev
update design
3270dfc
@Stepanokdev
Merge branch 'develop'
99d3ab0 
Conflicts:
	Core/Core/View/Base/FlexibleKeyboardInputView.swift
	Course/Course/Presentation/Unit/CourseUnitView.swift
	Course/Course/Presentation/Video/EncodedVideoPlayer.swift
	Course/Course/Presentation/Video/YouTubeVideoPlayer.swift
@Stepanokdev
resolve merge conflicts
bf9b534
@Stepanokdev
update progress dots
52b3325
@IvanStepanok
Copy link
Contributor Author

IvanStepanok commented Oct 13, 2023 •
edited
Loading

The paddings to progress dots are added.

Screenshot 2023-10-13 at 16 16 56

marcotuts
marcotuts approved these changes Oct 13, 2023
View reviewed changes
Copy link

@marcotuts marcotuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great on the product side! We can always make improvements to landscape support but getting a build with this enabled will be a huge help.

@Stepanokdev
bug fixes
abf3db2 
When a user swipes back from the problem screen, the app numbs and the user cannot tap. Fixed.
The component name is in the center of the screen. Fixed.
@Stepanokdev
code style improvements
6459522
@volodymyr-chekyrta volodymyr-chekyrta merged commit c42342e into openedx:develop Oct 16, 2023
1 check passed
@openedx-webhooks
Copy link

@IvanStepanok 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@volodymyr-chekyrta volodymyr-chekyrta deleted the feature/landscape-support branch October 16, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-chekyrta volodymyr-chekyrta volodymyr-chekyrta approved these changes

@marcotuts marcotuts marcotuts approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Landscape support
6 participants
@IvanStepanok @sdaitzman @openedx-webhooks @marcotuts @volodymyr-chekyrta @Stepanokdev