Transcript navigation #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display of video transcripts with active sentence highlighting. Tapping on transcript sentences to navigate to the corresponding part of the video. Mechanism to quickly return to the current active sentence after scrolling. https://github.com/openedx/openedx-app-ios/assets/128456094/b2cf1f49-e23b-42dd-a9b0-0ddac26bda59
|
To confirm - the video above shows the iOS transcript navigation for the Youtube player, can I confirm that this is also being added to the native iOS player? (Or perhaps that is a separate PR? ) |
|
Yes, sure. Here is proof: Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-10-11.at.12.53.20.mp4 |
|
No other input or suggestions from me this is good to go from product / design perspective |
volodymyr-chekyrta
approved these changes
Oct 13, 2023
openedx-webhooks
added
the
open-source-contribution
|
Although this pull request is already merged, I'm still watching it for updates. There is nothing you have to do. No action is needed from your side. Thanks again for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display of video transcripts with active sentence highlighting. Tapping on transcript sentences to navigate to the corresponding part of the video. Mechanism to quickly return to the current active sentence after scrolling.
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2023-10-06.at.12.21.17.mp4