Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Verify and Fix Course Level Empty Screens #454

Open
Tracked by #368
moiz994 opened this issue Jun 11, 2024 · 5 comments
Open
Tracked by #368

[iOS] Verify and Fix Course Level Empty Screens #454

moiz994 opened this issue Jun 11, 2024 · 5 comments
Assignees

Comments

@moiz994
Copy link

moiz994 commented Jun 11, 2024

We need to verify and fix empty states of the major modules within the course experience.

Case 1: Empty state for handouts
If there are no handouts in the course we need to show a screen letting the users know of this instead of showing an empty area under the pill navigation.

Icon to be used: https://www.figma.com/design/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?node-id=7569-52011&t=WPTCJ4I9SHy0sBji-4
image

Copy to be used: There are currently no handouts for this course.

Case 2: Empty Screen for announcements
Icon to be used: https://www.figma.com/design/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?node-id=12519-78253&t=WPTCJ4I9SHy0sBji-4
image

Copy to be used: There are currently no announcements for this course.

Case 3: Empty screen for videos
Icon to be used: https://www.figma.com/design/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?node-id=14629-260626&t=WPTCJ4I9SHy0sBji-4
image

Copy to be used: There are currently no vidoes for this course.

@moiz994 moiz994 changed the title Verify and Fix Course Level Error Handling Verify and Fix Course Level Empty Screens Jun 11, 2024
@moiz994
Copy link
Author

moiz994 commented Jun 11, 2024

@sdaitzman can you please verify the choice of icons for this task?

@moiz994 moiz994 changed the title Verify and Fix Course Level Empty Screens [iOS] Verify and Fix Course Level Empty Screens Jun 11, 2024
@sdaitzman
Copy link

sdaitzman commented Jun 11, 2024

Hi @moiz994, thanks for checking about these! The icons for cases 1 and 3 make sense to me.

For announcements, that icon is associated with an error state. I wonder if another Material Design Round icon could avoid that signifier? I'm happy to pull together a mockup with a few options, if that would be helpful. Either way, I can add these empty cases to Figma. I'm also adding this to the next mobile design weekly agenda.

announcement (still has some of the same issue, and looks similar to the discussion tab icon):
image

email:
image

mail_outline:
image

mark_email_unread (would imply new unread messages, so might make sense not to use this except for that state):
image

@moiz994
Copy link
Author

moiz994 commented Jun 12, 2024

Usually a megaphone (📣 / 📢) makes a good relation with announcements. Maybe we can see if there's a relevant icon to that?

@moiz994 moiz994 moved this to In Discovery / Definition in Open edX Mobile Roadmap Jun 12, 2024
@sdaitzman
Copy link

Great idea @moiz994, we could use this icon (Material Design Round calls this campaign)

image

@moiz994
Copy link
Author

moiz994 commented Jun 20, 2024

Thanks, Sam! Is it possible for you to create quick error screens for these cases? It'll help the devs a lot.

@moiz994 moiz994 moved this from In Discovery / Definition to In Code Review / Final Acceptance in Open edX Mobile Roadmap Jul 12, 2024
@rnr rnr linked a pull request Jul 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Code Review / Final Acceptance
Development

Successfully merging a pull request may close this issue.

3 participants